netdev - Re: [crypto 1/4] net/tls: connect routine for Inine TLS Client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201904120422.r5W3Tq50%lkp@intel.com>
Date:   Fri, 12 Apr 2019 04:43:49 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Atul Gupta <atul.gupta@...lsio.com>
Cc:     kbuild-all@...org, herbert@...dor.apana.org.au,
        davem@...emloft.net, linux-crypto@...r.kernel.org,
        netdev@...r.kernel.org, dt@...lsio.com, atul.gupta@...lsio.com
Subject: Re: [crypto 1/4] net/tls: connect routine for Inine TLS Client

Hi Atul,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on crypto/master]

url:    https://github.com/0day-ci/linux/commits/Atul-Gupta/Inline-TLS-client-and-v6-support/20190412-034407
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git master
config: i386-randconfig-x017-201914 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   net/tls/tls_main.c: In function 'tls_hw_connect':
>> net/tls/tls_main.c:641:9: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized]
     return err;
            ^~~

vim +/err +641 net/tls/tls_main.c

   621	
   622	static int tls_hw_connect(struct sock *sk, struct sockaddr *uaddr,
   623				  int addr_len)
   624	{
   625		struct tls_device *dev;
   626		int err;
   627	
   628		spin_lock_bh(&device_spinlock);
   629		list_for_each_entry(dev, &device_list, dev_list) {
   630			if (dev->connect) {
   631				kref_get(&dev->kref);
   632				spin_unlock_bh(&device_spinlock);
   633				err = dev->connect(dev, sk, uaddr, addr_len);
   634				kref_put(&dev->kref, dev->release);
   635				spin_lock_bh(&device_spinlock);
   636				if (!err)
   637					break;
   638			}
   639		}
   640		spin_unlock_bh(&device_spinlock);
 > 641		return err;
   642	}
   643	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (31058 bytes)