netdev - Re: [PATCH net] selftests: fib_tests: Fix 'Command line is not complete' errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190411.141823.1468157210604234195.davem@davemloft.net>
Date:   Thu, 11 Apr 2019 14:18:23 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, dsahern@...il.com
Subject: Re: [PATCH net] selftests: fib_tests: Fix 'Command line is not
 complete' errors

From: David Ahern <dsahern@...nel.org>
Date: Tue,  9 Apr 2019 14:23:10 -0700

> From: David Ahern <dsahern@...il.com>
> 
> A couple of tests are verifying a route has been removed. The helper
> expects the prefix as the first part of the expected output. When
> checking that a route has been deleted the prefix is empty leading
> to an invalid ip command:
> 
>   $ ip ro ls match
>   Command line is not complete. Try option "help"
> 
> Fix by moving the comparison of expected output and output to a new
> function that is used by both check_route and check_route6. Use the
> new helper for the 2 checks on route removal.
> 
> Also, remove the reset of 'set -x' in route_setup which overrides the
> user managed setting.
> 
> Fixes: d69faad76584c ("selftests: fib_tests: Add prefix route tests with metric")
> Signed-off-by: David Ahern <dsahern@...il.com>

Applied.