netdev - Re: [PATCH v5 1/5] sctp: Remove superfluous test in sctp_ulpq_reasm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190411221744.GM10452@localhost.localdomain>
Date:   Thu, 11 Apr 2019 19:17:44 -0300
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, lucien.xin@...il.com, nhorman@...driver.com
Subject: Re: [PATCH v5 1/5] sctp: Remove superfluous test in
 sctp_ulpq_reasm_drain().

On Thu, Apr 11, 2019 at 03:01:53PM -0700, David Miller wrote:
> 
> Inside the loop, we always start with event non-NULL.
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>

Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>

> ---
>  net/sctp/ulpqueue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/sctp/ulpqueue.c b/net/sctp/ulpqueue.c
> index 5dde92101743..0fecc1fb4ab7 100644
> --- a/net/sctp/ulpqueue.c
> +++ b/net/sctp/ulpqueue.c
> @@ -745,7 +745,7 @@ static void sctp_ulpq_reasm_drain(struct sctp_ulpq *ulpq)
>  
>  	while ((event = sctp_ulpq_retrieve_reassembled(ulpq)) != NULL) {
>  		/* Do ordering if needed.  */
> -		if ((event) && (event->msg_flags & MSG_EOR)) {
> +		if (event->msg_flags & MSG_EOR) {
>  			skb_queue_head_init(&temp);
>  			__skb_queue_tail(&temp, sctp_event2skb(event));
>  
> -- 
> 2.20.1
>