netdev - Re: iproute2: Issue with link type link/generic for NETROM links

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190411152506.2ce60464@shemminger-XPS-13-9360>
Date:   Thu, 11 Apr 2019 15:25:06 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Ralf Baechle <ralf@...ux-mips.org>
Cc:     netdev@...r.kernel.org
Subject: Re: iproute2: Issue with link type link/generic for NETROM links

On Thu, 4 Apr 2019 12:21:54 +0200
Ralf Baechle <ralf@...ux-mips.org> wrote:

> For a NETROM "ip link show dev nr0" will show
> 
> 4: nr0: <NOARP,UP,LOWER_UP> mtu 236 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1000
>     link/generic 88:98:6a:a4:84:40:0a brd 00:00:00:00:00:00:00
> 
> But rather link/netrom is expected to be displayed.
> 
> I have below patch to change ip such that link/netrom will be displayed
> but I'm wondering if it's going to cause non-obvious breakage or would
> be acceptable?
> 
> Thanks,
> 
>   Ralf
> 
> Signed-off-by: Ralf Baechle <ralf@...ux-mips.org>
> 
>  lib/ll_types.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/ll_types.c b/lib/ll_types.c
> index bd8893ed..32d04b5a 100644
> --- a/lib/ll_types.c
> +++ b/lib/ll_types.c
> @@ -32,7 +32,7 @@ static const struct {
>  	int type;
>  	const char *name;
>  } arphrd_names[] = {
> -{ 0, "generic" },
> +__PF(NETROM,netrom)
>  __PF(ETHER,ether)
>  __PF(EETHER,eether)
>  __PF(AX25,ax25)

Looks ok to me, but was a little concerned that it might break something else.
Will merge it and see.