netdev - Re: [PATCH net] net/tls: prevent bad memory access in tls_is_sk_tx_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190410.224318.1998418923205496987.davem@davemloft.net>
Date:   Wed, 10 Apr 2019 22:43:18 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     oss-drivers@...ronome.com, netdev@...r.kernel.org,
        alexei.starovoitov@...il.com, dirk.vandermerwe@...ronome.com,
        simon.horman@...ronome.com
Subject: Re: [PATCH net] net/tls: prevent bad memory access in
 tls_is_sk_tx_device_offloaded()

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Mon,  8 Apr 2019 17:59:50 -0700

> Unlike '&&' operator, the '&' does not have short-circuit
> evaluation semantics.  IOW both sides of the operator always
> get evaluated.  Fix the wrong operator in
> tls_is_sk_tx_device_offloaded(), which would lead to
> out-of-bounds access for for non-full sockets.
> 
> Fixes: 4799ac81e52a ("tls: Add rx inline crypto offload")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@...ronome.com>
> Reviewed-by: Simon Horman <simon.horman@...ronome.com>

Good catch, applied and queued up for -stable.