netdev - Re: [PATCH net] net: fou: do not use guehdr after iptunnel_pull_offloads in gue_udp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190411.000251.217482186199245334.davem@davemloft.net>
Date:   Thu, 11 Apr 2019 00:02:51 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lorenzo.bianconi@...hat.com
Cc:     netdev@...r.kernel.org, jesse@...nel.org
Subject: Re: [PATCH net] net: fou: do not use guehdr after
 iptunnel_pull_offloads in gue_udp_recv

From: Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
Date: Tue,  9 Apr 2019 11:47:20 +0200

> gue tunnels run iptunnel_pull_offloads on received skbs. This can
> determine a possible use-after-free accessing guehdr pointer since
> the packet will be 'uncloned' running pskb_expand_head if it is a
> cloned gso skb (e.g if the packet has been sent though a veth device)
> 
> Fixes: a09a4c8dd1ec ("tunnels: Remove encapsulation offloads on decap")
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@...hat.com>

Applied and queued up for -stable, thanks.