netdev - Re: [PATCH bpf-next] libbpf: Add xsk.h to be installed by install

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13E3E635-168E-492A-9EBB-BF18620E46A0@fb.com>
Date:   Fri, 12 Apr 2019 16:58:44 +0000
From:   Song Liu <songliubraving@...com>
To:     Stanislav Fomichev <sdf@...ichev.me>
CC:     Eelco Chaudron <echaudro@...hat.com>,
        Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin Lau <kafai@...com>, Yonghong Song <yhs@...com>,
        "magnus.karlsson@...el.com" <magnus.karlsson@...el.com>
Subject: Re: [PATCH bpf-next] libbpf: Add xsk.h to be installed by
 install_headers



> On Apr 12, 2019, at 9:31 AM, Stanislav Fomichev <sdf@...ichev.me> wrote:
> 
> On 04/12, Song Liu wrote:
>> 
>> 
>>> On Apr 12, 2019, at 7:17 AM, Eelco Chaudron <echaudro@...hat.com> wrote:
>>> 
>>> The user API file xsk.h was not installed by install_headers, this
>>> change will fix this.
>>> 
>>> Signed-off-by: Eelco Chaudron <echaudro@...hat.com>
>> 
>> Cc: Magnus Karlsson <magnus.karlsson@...el.com>
>> Fixes: 1cad07884239 ("libbpf: add support for using AF_XDP sockets")
>> Acked-by: Song Liu <songliubraving@...com>
> Isn't it already in? See commit 379e2014c95b7 ("libbpf: add xsk.h to
> install_headers target").

Good catch!

Thanks Stanislav!

Song



>>> ---
>>> tools/lib/bpf/Makefile | 1 +
>>> 1 file changed, 1 insertion(+)
>>> 
>>> diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
>>> index 008344507700..9b0a0f53d640 100644
>>> --- a/tools/lib/bpf/Makefile
>>> +++ b/tools/lib/bpf/Makefile
>>> @@ -230,6 +230,7 @@ install_headers:
>>> 		$(call do_install,bpf.h,$(prefix)/include/bpf,644); \
>>> 		$(call do_install,libbpf.h,$(prefix)/include/bpf,644);
>>> 		$(call do_install,btf.h,$(prefix)/include/bpf,644);
>>> +		$(call do_install,xsk.h,$(prefix)/include/bpf,644);
>>> 
>>> install_pkgconfig: $(PC_FILE)
>>> 	$(call QUIET_INSTALL, $(PC_FILE)) \
>>> -- 
>>> 2.18.1
>>> 
>>