netdev - Re: [PATCH bpf-next] bpf: Fix distinct pointer types warning for ARCH=i386

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 12 Apr 2019 16:14:58 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Andrey Ignatov <rdna@...com>
Cc:     Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next] bpf: Fix distinct pointer types warning for ARCH=i386

On Fri, Apr 12, 2019 at 4:01 PM Andrey Ignatov <rdna@...com> wrote:
>
> Fix a new warning reported by kbuild for make ARCH=i386:
>
>    In file included from kernel/bpf/cgroup.c:11:0:
>    kernel/bpf/cgroup.c: In function '__cgroup_bpf_run_filter_sysctl':
>    include/linux/kernel.h:827:29: warning: comparison of distinct pointer types lacks a cast
>       (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
>                                 ^
>    include/linux/kernel.h:841:4: note: in expansion of macro '__typecheck'
>       (__typecheck(x, y) && __no_side_effects(x, y))
>        ^~~~~~~~~~~
>    include/linux/kernel.h:851:24: note: in expansion of macro '__safe_cmp'
>      __builtin_choose_expr(__safe_cmp(x, y), \
>                            ^~~~~~~~~~
>    include/linux/kernel.h:860:19: note: in expansion of macro '__careful_cmp'
>     #define min(x, y) __careful_cmp(x, y, <)
>                       ^~~~~~~~~~~~~
> >> kernel/bpf/cgroup.c:837:17: note: in expansion of macro 'min'
>       ctx.new_len = min(PAGE_SIZE, *pcount);
>                     ^~~
>
> Fixes: 4e63acdff864 ("bpf: Introduce bpf_sysctl_{get,set}_new_value helpers")
> Signed-off-by: Andrey Ignatov <rdna@...com>

Applied. Thanks for the quick fix.