netdev - Re: [crypto 3/4] crypto/chelsio/chtls: CPL for TLS client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 12 Apr 2019 12:57:40 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Atul Gupta <atul.gupta@...lsio.com>
Cc:     kbuild-all@...org, herbert@...dor.apana.org.au,
        davem@...emloft.net, linux-crypto@...r.kernel.org,
        netdev@...r.kernel.org, dt@...lsio.com, atul.gupta@...lsio.com
Subject: Re: [crypto 3/4] crypto/chelsio/chtls: CPL for TLS client

Hi Atul,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on crypto/master]

url:    https://github.com/0day-ci/linux/commits/Atul-Gupta/Inline-TLS-client-and-v6-support/20190412-034407
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git master
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'


sparse warnings: (new ones prefixed by >>)

   drivers/crypto/chelsio/chtls/chtls_cm.c:1333:42: sparse: incorrect type in assignment (different base types) @@    expected restricted __be32 [usertype] atid_status @@    got e] atid_status @@
   drivers/crypto/chelsio/chtls/chtls_cm.c:1333:42:    expected restricted __be32 [usertype] atid_status
   drivers/crypto/chelsio/chtls/chtls_cm.c:1333:42:    got int
>> drivers/crypto/chelsio/chtls/chtls_cm.c:54:6: sparse: symbol 'chtls_sock_release' was not declared. Should it be static?
   drivers/crypto/chelsio/chtls/chtls_cm.c:1155:17: sparse: expression using sizeof(void)
>> drivers/crypto/chelsio/chtls/chtls_cm.c:1342:6: sparse: symbol 'chtls_handshake_work' was not declared. Should it be static?
>> drivers/crypto/chelsio/chtls/chtls_cm.c:1362:6: sparse: symbol 'chtls_fix_pending_tx_buffers' was not declared. Should it be static?
>> drivers/crypto/chelsio/chtls/chtls_cm.c:1389:23: sparse: incorrect type in argument 1 (different address spaces) @@    expected struct dst_entry *dst @@    got struct dst_entry struct dst_entry *dst @@
   drivers/crypto/chelsio/chtls/chtls_cm.c:1389:23:    expected struct dst_entry *dst
   drivers/crypto/chelsio/chtls/chtls_cm.c:1389:23:    got struct dst_entry [noderef] <asn:4>*sk_dst_cache
   drivers/crypto/chelsio/chtls/chtls_cm.c:1500:40: sparse: incorrect type in argument 1 (different address spaces) @@    expected struct socket_wq *wq @@    got struct socket_wq struct socket_wq *wq @@
   drivers/crypto/chelsio/chtls/chtls_cm.c:1500:40:    expected struct socket_wq *wq
   drivers/crypto/chelsio/chtls/chtls_cm.c:1500:40:    got struct socket_wq [noderef] <asn:4>*sk_wq
   drivers/crypto/chelsio/chtls/chtls_cm.c:1501:25: sparse: cast to restricted __poll_t
   drivers/crypto/chelsio/chtls/chtls_cm.c:1548:16: sparse: expression using sizeof(void)
   drivers/crypto/chelsio/chtls/chtls_cm.c:1698:60: sparse: Using plain integer as NULL pointer
   drivers/crypto/chelsio/chtls/chtls_cm.c:2795:39: sparse: incorrect type in argument 1 (different address spaces) @@    expected struct dst_entry *dst @@    got struct dst_entry struct dst_entry *dst @@
   drivers/crypto/chelsio/chtls/chtls_cm.c:2795:39:    expected struct dst_entry *dst
   drivers/crypto/chelsio/chtls/chtls_cm.c:2795:39:    got struct dst_entry [noderef] <asn:4>*sk_dst_cache
   drivers/crypto/chelsio/chtls/chtls_cm.c:1801:22: sparse: context imbalance in 'chtls_recv_sock' - unexpected unlock

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation