netdev - Re: [PATCH v3 bpf-next 11/19] libbpf: add "prog_flags" to bpf_program/bpf_prog_load_attr/bpf_load_program

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 12 Apr 2019 18:08:48 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Jiong Wang <jiong.wang@...ronome.com>
Cc:     alexei.starovoitov@...il.com, daniel@...earbox.net,
        bpf@...r.kernel.org, netdev@...r.kernel.org,
        oss-drivers@...ronome.com
Subject: Re: [PATCH v3 bpf-next 11/19] libbpf: add "prog_flags" to
 bpf_program/bpf_prog_load_attr/bpf_load_program_attr

On Fri, 12 Apr 2019 22:59:44 +0100, Jiong Wang wrote:
> libbpf doesn't allow passing "prog_flags" during bpf program load in a
> couple of load related APIs, "bpf_load_program_xattr", "load_program" and
> "bpf_prog_load_xattr".
> 
> It makes sense to allow passing "prog_flags" which is useful for
> customizing program loading.
> 
> Signed-off-by: Jiong Wang <jiong.wang@...ronome.com>

Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Thanks!

> diff --git a/tools/lib/bpf/libbpf.h b/tools/lib/bpf/libbpf.h
> index c5ff005..5abc237 100644
> --- a/tools/lib/bpf/libbpf.h
> +++ b/tools/lib/bpf/libbpf.h
> @@ -320,6 +320,7 @@ struct bpf_prog_load_attr {
>  	enum bpf_attach_type expected_attach_type;
>  	int ifindex;
>  	int log_level;
> +	int prog_flags;

nit: __u32 or other unsigned type here?

>  };
>  
>  LIBBPF_API int bpf_prog_load_xattr(const struct bpf_prog_load_attr *attr,