netdev - Re: [PATCH net] ipv4: recompile ip options in ipv4_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2414eaeb-7b6f-f5cf-e4b4-744b11d5641e@gmail.com>
Date:   Sat, 13 Apr 2019 16:44:41 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     David Miller <davem@...emloft.net>, ssuryaextr@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] ipv4: recompile ip options in ipv4_link_failure



On 04/12/2019 05:24 PM, David Miller wrote:
> From: Stephen Suryaputra <ssuryaextr@...il.com>
> Date: Fri, 12 Apr 2019 16:19:27 -0400
> 
>> Recompile IP options since IPCB may not be valid anymore when
>> ipv4_link_failure is called from arp_error_report.
>>
>> Refer to the commit 3da1ed7ac398 ("net: avoid use IPCB in cipso_v4_error")
>> and the commit before that (9ef6b42ad6fd) for a similar issue.
>>
>> Signed-off-by: Stephen Suryaputra <ssuryaextr@...il.com>
> 
> Applied.
> 

I believe __ip_options_compile() needs to be called from rcu_read_lock()

I will send a fix.