netdev - [PATCH v3 net-next 12/24] net: dsa: Copy the vlan_filtering setting on the CPU port if it's global

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190413012822.30931-13-olteanv@gmail.com>
Date:   Sat, 13 Apr 2019 04:28:10 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     f.fainelli@...il.com, vivien.didelot@...il.com, andrew@...n.ch,
        davem@...emloft.net
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        georg.waibel@...sor-technik.de, Vladimir Oltean <olteanv@...il.com>
Subject: [PATCH v3 net-next 12/24] net: dsa: Copy the vlan_filtering setting on the CPU port if it's global

The current behavior is not as obvious as one would assume (which is
that, if the driver set vlan_filtering_is_global = 1, then checking any
dp->vlan_filtering would yield the same result). Only the ports which
are actively enslaved into a bridge would have vlan_filtering set.

This makes it tricky for drivers to check what the global state is.
Moreover, the most obvious place to check for this setting, the CPU
port, is not populated since it's not being enslaved to the bridge.
So fix this and make the CPU port hold the global state of VLAN
filtering on this switch.

Signed-off-by: Vladimir Oltean <olteanv@...il.com>
---
Changes in v3:
Patch is new.

 net/dsa/port.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/net/dsa/port.c b/net/dsa/port.c
index c8eb2cbcea6e..acb4ed1f9929 100644
--- a/net/dsa/port.c
+++ b/net/dsa/port.c
@@ -190,6 +190,8 @@ static bool dsa_port_can_apply_vlan_filtering(struct dsa_port *dp,
 int dsa_port_vlan_filtering(struct dsa_port *dp, bool vlan_filtering,
 			    struct switchdev_trans *trans)
 {
+	/* Violate a const pointer here */
+	struct dsa_port *cpu_dp = (struct dsa_port *)dp->cpu_dp;
 	struct dsa_switch *ds = dp->ds;
 	int err;
 
@@ -209,6 +211,12 @@ int dsa_port_vlan_filtering(struct dsa_port *dp, bool vlan_filtering,
 		return err;
 
 	dp->vlan_filtering = vlan_filtering;
+	/* In case of switches where VLAN filtering is not per-port,
+	 * also put the setting in the most unambiguous place to
+	 * retrieve it from.
+	 */
+	if (ds->vlan_filtering_is_global)
+		cpu_dp->vlan_filtering = vlan_filtering;
 	return 0;
 }
 
-- 
2.17.1