netdev - Re: [PATCH net] rtnetlink: fix rtnl_valid_stats_req() nlmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190414.141117.1616689033265337055.davem@davemloft.net>
Date:   Sun, 14 Apr 2019 14:11:17 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        syzkaller@...glegroups.com, jakub.kicinski@...ronome.com
Subject: Re: [PATCH net] rtnetlink: fix rtnl_valid_stats_req() nlmsg_len
 check

From: Eric Dumazet <edumazet@...gle.com>
Date: Sun, 14 Apr 2019 11:02:05 -0700

> Jakub forgot to either use nlmsg_len() or nlmsg_msg_size(),
> allowing KMSAN to detect a possible uninit-value in rtnl_stats_get
 ...
> Fixes: 51bc860d4a99 ("rtnetlink: stats: validate attributes in get as well as dumps")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>
> Cc: Jakub Kicinski <jakub.kicinski@...ronome.com>

Applied, thanks Eric.