netdev - Re: [PATCH net-next 2/3] mlxsw: spectrum_router: Add neighbour offload indication

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e69f6208-8af5-5e81-a72f-77705c56d83a@gmail.com>
Date:   Sun, 14 Apr 2019 18:37:59 -0600
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        Jiri Pirko <jiri@...lanox.com>, mlxsw <mlxsw@...lanox.com>
Subject: Re: [PATCH net-next 2/3] mlxsw: spectrum_router: Add neighbour
 offload indication

On 4/14/19 12:57 PM, Ido Schimmel wrote:
> In a similar fashion to routes and FDB entries, the neighbour table is
> reflected to the device.
> 
> Set an offload indication on the neighbour in case it was programmed to
> the device.
> 
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Acked-by: Jiri Pirko <jiri@...lanox.com>
> ---
>  drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
> index e159b246ba55..31656a2a6252 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
> @@ -2444,7 +2444,13 @@ mlxsw_sp_neigh_entry_update(struct mlxsw_sp *mlxsw_sp,
>  			return;
>  	} else {
>  		WARN_ON_ONCE(1);
> +		return;
>  	}
> +
> +	if (adding)
> +		neigh_entry->key.n->flags |= NTF_OFFLOADED;
> +	else
> +		neigh_entry->key.n->flags &= ~NTF_OFFLOADED;
>  }
>  
>  void
> 

Reviewed-by: David Ahern <dsahern@...il.com>