netdev - Re: [PATCH v3 bpf-next 04/19] bpf: refactor "check_reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQJ8osYBje-TAewjGTULJyS3-Epu48VmxWw7JcDXTrChGQ@mail.gmail.com>
Date:   Sun, 14 Apr 2019 22:41:49 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Jiong Wang <jiong.wang@...ronome.com>
Cc:     Daniel Borkmann <daniel@...earbox.net>, bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        oss-drivers@...ronome.com
Subject: Re: [PATCH v3 bpf-next 04/19] bpf: refactor "check_reg_arg" to
 eliminate code redundancy

On Sat, Apr 13, 2019 at 12:01 AM Jiong Wang <jiong.wang@...ronome.com> wrote:
>
>
> Alexei Starovoitov writes:
>
> > On Fri, Apr 12, 2019 at 10:59:37PM +0100, Jiong Wang wrote:
> >> There are a few "regs[regno]" here are there across "check_reg_arg", this
> >> patch factor it out into a simple "reg" pointer. The intention is to
> >> simplify code indentation and make the later patches in this set look
> >> cleaner.
> >>
> >> Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> >> Signed-off-by: Jiong Wang <jiong.wang@...ronome.com>
> >
> > The first 4 patches look great, so I've applied them to bpf-next.
>
> Thanks.
>
> > The rest needs more careful review that we'll do soon.
>
> No problem and agree they need very careful review. I understand once
> landed the optimization will be always on for a couple of targets like Arm,
> PowerPC and SPARC etc, so the correctness is critical.
>
> Patch 5 has two comments from Jakub not addressed, they are not about
> correctness so should not affect the review, I will fix them together with
> the other new comments.
>
> One good thing is high 32-bit randomization does catch a couple of corner
> case bugs so prove to be very powerful and efficient for exposing bugs. In
> v3, it is enabled on all possible tests under bpf selftests, and I haven't
> noticed regressions (my local machine configure may caused some tests
> skipped, but majority of the testsuite, especially all tests under
> test_progs/test_progs_32/test_verifier ran without failure), this is a good
> assurance of correctness.

Sounds great, but please respin the rest of patches with comments addressed.
Don't worry about spamming the mailing list.