netdev - Re: [patch net-next rfc 02/15] netdevsim: create devlink instance per netdevsim instance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e024c38-0368-1dae-4be5-07b34d596a58@gmail.com>
Date:   Mon, 15 Apr 2019 09:07:04 -0600
From:   David Ahern <dsahern@...il.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, mlxsw@...lanox.com,
        jakub.kicinski@...ronome.com
Subject: Re: [patch net-next rfc 02/15] netdevsim: create devlink instance per
 netdevsim instance

On 4/14/19 11:41 PM, Jiri Pirko wrote:
> Mon, Apr 15, 2019 at 04:24:24AM CEST, dsahern@...il.com wrote:
>> On 4/13/19 10:20 AM, Jiri Pirko wrote:
>>> From: Jiri Pirko <jiri@...lanox.com>
>>>
>>> Currently there is one devlink instance created per network namespace.
>>> That is quite odd considering the fact that devlink instance should
>>> represent an ASIC. The following patches are going to move the devlink
>>> instance even more down to a bus device, but until then, have one
>>> devlink instance per netdevsim instance. Struct nsim_devlink is
>>> introduced to hold fib setting.
>>>
>>> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
>>> ---
>>>  drivers/net/netdevsim/devlink.c   | 179 +++++++++++-------------------
>>>  drivers/net/netdevsim/fib.c       | 103 +++++++----------
>>>  drivers/net/netdevsim/netdev.c    |  27 ++---
>>>  drivers/net/netdevsim/netdevsim.h |  18 +--
>>>  4 files changed, 125 insertions(+), 202 deletions(-)
>>
>> you are making a lot of changes to how fib events are handled and not
>> explaining what you are doing.
> 
> They are handled in the exact same way. This is just about devlink
> instance. Will add that to description.
> 


Data is currently stored as a net_generic. You are changing that. The
changelog should state that.