netdev - Re: [PATCH net] route: Avoid crash from dereferencing NULL rt->from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37ff4eb2-d791-a0f8-0196-a99b4f232f63@gmail.com>
Date:   Mon, 15 Apr 2019 13:16:00 -0600
From:   David Ahern <dsahern@...il.com>
To:     Martin Lau <kafai@...com>
Cc:     Jonathan Lemon <jonathan.lemon@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH net] route: Avoid crash from dereferencing NULL rt->from

On 4/15/19 10:17 AM, Martin Lau wrote:
> Hi David,  is similar check also needed in rt6_do_redirect() and
> inet6_rtm_getroute()?

good question. I think both could be returning an rt6_info from the
exception cache so yes they should have a similar check.