netdev - Re: [PATCH net] bonding: fix event handling for stacked bonds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 15 Apr 2019 13:23:00 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     sd@...asysnail.net
Cc:     netdev@...r.kernel.org, j.vosburgh@...il.com, vfalico@...il.com,
        andy@...yhouse.net, jarod@...hat.com
Subject: Re: [PATCH net] bonding: fix event handling for stacked bonds

From: Sabrina Dubroca <sd@...asysnail.net>
Date: Fri, 12 Apr 2019 15:04:10 +0200

> When a bond is enslaved to another bond, bond_netdev_event() only
> handles the event as if the bond is a master, and skips treating the
> bond as a slave.
> 
> This leads to a refcount leak on the slave, since we don't remove the
> adjacency to its master and the master holds a reference on the slave.
> 
> Reproducer:
>   ip link add bondL type bond
>   ip link add bondU type bond
>   ip link set bondL master bondU
>   ip link del bondL
> 
> No "Fixes:" tag, this code is older than git history.
> 
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>

Applied and queued up for -stable, thanks Sabrina.