netdev - Re: [patch net-next rfc 02/15] netdevsim: create devlink instance per netdevsim instance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <519cfd86-dcc8-9dc4-1929-71ea1084689b@gmail.com>
Date:   Sun, 14 Apr 2019 20:24:24 -0600
From:   David Ahern <dsahern@...il.com>
To:     Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, mlxsw@...lanox.com,
        jakub.kicinski@...ronome.com
Subject: Re: [patch net-next rfc 02/15] netdevsim: create devlink instance per
 netdevsim instance

On 4/13/19 10:20 AM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...lanox.com>
> 
> Currently there is one devlink instance created per network namespace.
> That is quite odd considering the fact that devlink instance should
> represent an ASIC. The following patches are going to move the devlink
> instance even more down to a bus device, but until then, have one
> devlink instance per netdevsim instance. Struct nsim_devlink is
> introduced to hold fib setting.
> 
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
> ---
>  drivers/net/netdevsim/devlink.c   | 179 +++++++++++-------------------
>  drivers/net/netdevsim/fib.c       | 103 +++++++----------
>  drivers/net/netdevsim/netdev.c    |  27 ++---
>  drivers/net/netdevsim/netdevsim.h |  18 +--
>  4 files changed, 125 insertions(+), 202 deletions(-)

you are making a lot of changes to how fib events are handled and not
explaining what you are doing.