netdev - Re: [PATCH v2 net-next] net: phy: switch drivers to use dynamic feature detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190415.172017.1299396646743801898.davem@davemloft.net>
Date:   Mon, 15 Apr 2019 17:20:17 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, rjui@...adcom.com,
        sbranden@...adcom.com, richardcochran@...il.com,
        khilman@...libre.com, heiko@...ech.de,
        bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v2 net-next] net: phy: switch drivers to use dynamic
 feature detection

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Fri, 12 Apr 2019 20:47:03 +0200

> Recently genphy_read_abilities() has been added that dynamically detects
> clause 22 PHY abilities. I *think* this detection should work with all
> supported PHY's, at least for the ones with basic features sets, i.e.
> PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting these
> features explicitly and rely on phylib feature detection.
> 
> I don't have access to most of these PHY's, therefore I'd appreciate
> regression testing.
> 
> v2:
> - make the feature constant a comment so that readers know which
>   features are supported by the respective PHY
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied, thanks Heiner.