netdev - Re: [PATCH bpf-next 1/2] tools/bpftool: re-organize newline printing for map listing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D9B72A81-FF62-4CCA-A663-2E13803910C2@fb.com>
Date:   Tue, 16 Apr 2019 20:30:18 +0000
From:   Song Liu <songliubraving@...com>
To:     Quentin Monnet <quentin.monnet@...ronome.com>
CC:     Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Martin Lau <kafai@...com>, Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andriin@...com>,
        "prashantbhole.linux@...il.com" <prashantbhole.linux@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH bpf-next 1/2] tools/bpftool: re-organize newline printing
 for map listing



> On Apr 16, 2019, at 2:22 AM, Quentin Monnet <quentin.monnet@...ronome.com> wrote:
> 
> 2019-04-16 17:59 UTC+0900 ~ Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>
>> Let's move the final newline printing in show_map_close_plain() at
>> the end of the function because it looks correct and consistent with
>> prog.c. Also let's do related changes for the line which prints
>> pinned file name.
>> Signed-off-by: Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>

Acked-by: Song Liu <songliubraving@...com>

>> ---
>>  tools/bpf/bpftool/map.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>> diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c
>> index e96903078991..cda0f27fa895 100644
>> --- a/tools/bpf/bpftool/map.c
>> +++ b/tools/bpf/bpftool/map.c
>> @@ -604,15 +604,16 @@ static int show_map_close_plain(int fd, struct bpf_map_info *info)
>>  	}
>>  	close(fd);
>>  -	printf("\n");
>>  	if (!hash_empty(map_table.table)) {
>>  		struct pinned_obj *obj;
>>    		hash_for_each_possible(map_table.table, obj, hash, info->id) {
>>  			if (obj->id == info->id)
>> -				printf("\tpinned %s\n", obj->path);
>> +				printf("\n\tpinned %s", obj->path);
>>  		}
>>  	}
>> +
>> +	printf("\n");
>>  	return 0;
>>  }
>>  
> 
> Reviewed-by: Quentin Monnet <quentin.monnet@...ronome.com>
> Thanks!