netdev - Re: [PATCH bpf-next] libbpf: fix printf formatter for ptrdiff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPhsuW5L1hdsy3wHMo+Fsc89iv-HoXki7rnwnbqo1qnLjnsF+Q@mail.gmail.com>
Date:   Tue, 16 Apr 2019 14:27:34 -0700
From:   Song Liu <liu.song.a23@...il.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        evvers@...ru, Andrii Nakryiko <andriin@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...com>, Yonghong Song <yhs@...com>
Subject: Re: [PATCH bpf-next] libbpf: fix printf formatter for ptrdiff_t argument

On Tue, Apr 16, 2019 at 11:47 AM <andrii.nakryiko@...il.com> wrote:
>
> From: Andrii Nakryiko <andriin@...com>
>
> Using %ld for printing out value of ptrdiff_t type is not portable
> between 32-bit and 64-bit archs. This is causing compilation errors for
> libbpf on 32-bit platform (discovered as part of an effort to integrate
> libbpf into systemd ([0])). Proper formatter is %td, which is used in
> this patch.
>
> v2->v1:
>   - add Reported-by
>   - provide more context on how this issue was discovered
>
> [0] https://github.com/systemd/systemd/pull/12151
>
> Reported-by: Evgeny Vereshchagin <evvers@...ru>
> Cc: Daniel Borkmann <daniel@...earbox.net>
> Cc: Alexei Starovoitov <ast@...com>
> Cc: Yonghong Song <yhs@...com>
> Signed-off-by: Andrii Nakryiko <andriin@...com>

Acked-by: Song Liu <songliubraving@...com>


> ---
>  tools/lib/bpf/libbpf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index e5b77ad97795..d817bf20f3d6 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -817,7 +817,7 @@ bpf_object__init_internal_map(struct bpf_object *obj, struct bpf_map *map,
>                 memcpy(*data_buff, data->d_buf, data->d_size);
>         }
>
> -       pr_debug("map %ld is \"%s\"\n", map - obj->maps, map->name);
> +       pr_debug("map %td is \"%s\"\n", map - obj->maps, map->name);
>         return 0;
>  }
>
> --
> 2.17.1
>