netdev - Re: [PATCH bpf-next 2/2] tools/bpftool: show btf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190416143650.4f7fa360@cakuba.netronome.com>
Date:   Tue, 16 Apr 2019 14:36:50 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Quentin Monnet <quentin.monnet@...ronome.com>
Cc:     Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andriin@...com>,
        prashantbhole.linux@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next 2/2] tools/bpftool: show btf_id in map listing

On Tue, 16 Apr 2019 10:22:15 +0100, Quentin Monnet wrote:
> > diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c
> > index cda0f27fa895..de3e4cb32d21 100644
> > --- a/tools/bpf/bpftool/map.c
> > +++ b/tools/bpf/bpftool/map.c
> > @@ -550,6 +550,9 @@ static int show_map_close_json(int fd, struct bpf_map_info *info)
> >   		jsonw_end_array(json_wtr);
> >   	}
> >   
> > +	if (info->btf_id)
> > +		jsonw_int_field(json_wtr, "btf_id", info->btf_id);
> > +  
> 
> Just as a note, if you want to have things more consistent with prog.c, 
> you could print the btf_id _before_ the paths of pinned maps in JSON, 
> since this is what you did for programs.

+1, otherwise:

Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

for both patches, thanks!