netdev - Re: [PATCH net-next] net: phy: bcm87xx: improve feature configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fc48fb9-4f99-dbd0-8784-c40b61f91ac9@gmail.com>
Date:   Wed, 17 Apr 2019 00:34:18 +0200
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: phy: bcm87xx: improve feature configuration

On 17.04.2019 00:25, Andrew Lunn wrote:
>> @@ -194,7 +191,7 @@ static struct phy_driver bcm87xx_driver[] = {
>>  	.phy_id		= PHY_ID_BCM8706,
>>  	.phy_id_mask	= 0xffffffff,
>>  	.name		= "Broadcom BCM8706",
>> -	.features	= PHY_10GBIT_FEC_FEATURES,
>> +	.get_features	= bcm87xx_get_features,
>>  	.config_init	= bcm87xx_config_init,
>>  	.config_aneg	= bcm87xx_config_aneg,
>>  	.read_status	= bcm87xx_read_status,
>> @@ -206,7 +203,7 @@ static struct phy_driver bcm87xx_driver[] = {
>>  	.phy_id		= PHY_ID_BCM8727,
>>  	.phy_id_mask	= 0xffffffff,
>>  	.name		= "Broadcom BCM8727",
>> -	.features	= PHY_10GBIT_FEC_FEATURES,
>> +	.get_features	= bcm87xx_get_features,
>>  	.config_init	= bcm87xx_config_init,
>>  	.config_aneg	= bcm87xx_config_aneg,
>>  	.read_status	= bcm87xx_read_status,
> 
> Hi Heiner
> 
> The product briefs for these two devices say:
> 
> MDIO interface compliant to IEEE802.3ae Clause 45 with
> extended indirect address register access
> 
> It might be possible to just detect most of this?
> 
Unfortunately I have no datasheet. There would be more things to
fix in this old driver. The C45 register accesses should be
switched to proper phy_mmd_read/write calls.

> Florian: Do you have access to any boards using these devices?
> 
> 	 Andrew
> 
Heiner