| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Apr 2019 10:29:48 +0800
From: kbuild test robot <lkp@...el.com>
To: David Bauer <mail@...id-bauer.net>
Cc: kbuild-all@...org, devicetree@...r.kernel.org,
netdev@...r.kernel.org
Subject: Re: [PATCH 3/3] net: mdio: rename mdio_device reset to reset_gpio
Hi David,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net/master]
[also build test WARNING on v5.1-rc5 next-20190415]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/David-Bauer/dt-bindings-net-add-PHY-reset-controller-binding/20190416-061343
config: i386-randconfig-x006-201915 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
In file included from include/linux/phy.h:19:0,
from drivers/net/phy/at803x.c:10:
drivers/net/phy/at803x.c: In function 'at803x_link_change_notify':
drivers/net/phy/at803x.c:337:19: error: 'struct mdio_device' has no member named 'reset'
if (phydev->mdio.reset && !priv->phy_reset) {
^
include/linux/compiler.h:58:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> drivers/net/phy/at803x.c:337:3: note: in expansion of macro 'if'
if (phydev->mdio.reset && !priv->phy_reset) {
^~
drivers/net/phy/at803x.c:337:19: error: 'struct mdio_device' has no member named 'reset'
if (phydev->mdio.reset && !priv->phy_reset) {
^
include/linux/compiler.h:58:42: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> drivers/net/phy/at803x.c:337:3: note: in expansion of macro 'if'
if (phydev->mdio.reset && !priv->phy_reset) {
^~
drivers/net/phy/at803x.c:337:19: error: 'struct mdio_device' has no member named 'reset'
if (phydev->mdio.reset && !priv->phy_reset) {
^
include/linux/compiler.h:69:16: note: in definition of macro '__trace_if'
______r = !!(cond); \
^~~~
>> drivers/net/phy/at803x.c:337:3: note: in expansion of macro 'if'
if (phydev->mdio.reset && !priv->phy_reset) {
^~
vim +/if +337 drivers/net/phy/at803x.c
77a993942 Zhao Qiang 2014-03-28 324
13a56b449 Daniel Mack 2014-06-18 325 static void at803x_link_change_notify(struct phy_device *phydev)
13a56b449 Daniel Mack 2014-06-18 326 {
13a56b449 Daniel Mack 2014-06-18 327 struct at803x_priv *priv = phydev->priv;
13a56b449 Daniel Mack 2014-06-18 328
13a56b449 Daniel Mack 2014-06-18 329 /*
13a56b449 Daniel Mack 2014-06-18 330 * Conduct a hardware reset for AT8030 every time a link loss is
13a56b449 Daniel Mack 2014-06-18 331 * signalled. This is necessary to circumvent a hardware bug that
13a56b449 Daniel Mack 2014-06-18 332 * occurs when the cable is unplugged while TX packets are pending
13a56b449 Daniel Mack 2014-06-18 333 * in the FIFO. In such cases, the FIFO enters an error mode it
13a56b449 Daniel Mack 2014-06-18 334 * cannot recover from by software.
13a56b449 Daniel Mack 2014-06-18 335 */
13a56b449 Daniel Mack 2014-06-18 336 if (phydev->state == PHY_NOLINK) {
bafbdd527 Sergei Shtylyov 2017-12-04 @337 if (phydev->mdio.reset && !priv->phy_reset) {
13a56b449 Daniel Mack 2014-06-18 338 struct at803x_context context;
13a56b449 Daniel Mack 2014-06-18 339
13a56b449 Daniel Mack 2014-06-18 340 at803x_context_save(phydev, &context);
13a56b449 Daniel Mack 2014-06-18 341
bafbdd527 Sergei Shtylyov 2017-12-04 342 phy_device_reset(phydev, 1);
13a56b449 Daniel Mack 2014-06-18 343 msleep(1);
bafbdd527 Sergei Shtylyov 2017-12-04 344 phy_device_reset(phydev, 0);
d57019d18 Sergei Shtylyov 2016-03-23 345 msleep(1);
13a56b449 Daniel Mack 2014-06-18 346
13a56b449 Daniel Mack 2014-06-18 347 at803x_context_restore(phydev, &context);
13a56b449 Daniel Mack 2014-06-18 348
72ba48be3 Andrew Lunn 2016-01-06 349 phydev_dbg(phydev, "%s(): phy was reset\n",
13a56b449 Daniel Mack 2014-06-18 350 __func__);
13a56b449 Daniel Mack 2014-06-18 351 priv->phy_reset = true;
13a56b449 Daniel Mack 2014-06-18 352 }
13a56b449 Daniel Mack 2014-06-18 353 } else {
13a56b449 Daniel Mack 2014-06-18 354 priv->phy_reset = false;
13a56b449 Daniel Mack 2014-06-18 355 }
13a56b449 Daniel Mack 2014-06-18 356 }
13a56b449 Daniel Mack 2014-06-18 357
:::::: The code at line 337 was first introduced by commit
:::::: bafbdd527d569c8200521f2f7579f65a044271be phylib: Add device reset GPIO support
:::::: TO: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
:::::: CC: David S. Miller <davem@...emloft.net>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Download attachment ".config.gz" of type "application/gzip" (34277 bytes)
Powered by blists - more mailing lists