netdev - Re: [PATCH] [NETFILTER]: nf_conntrack_h323: fix spelling mistake "authenticaton" -> "authentication"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 16 Apr 2019 10:18:50 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Florian Westphal <fw@...len.de>, Mukesh Ojha <mojha@...eaurora.org>
Cc:     Pablo Neira Ayuso <pablo@...filter.org>,
        Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        "David S . Miller" <davem@...emloft.net>,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [NETFILTER]: nf_conntrack_h323: fix spelling mistake
 "authenticaton" -> "authentication"

On 16/04/2019 10:12, Florian Westphal wrote:
> On 4/15/2019 5:14 PM, Colin King wrote:
>>> diff --git a/net/netfilter/nf_conntrack_h323_types.c b/net/netfilter/nf_conntrack_h323_types.c
>>> index d880f3523c1d..95a0b3d6b24d 100644
>>> --- a/net/netfilter/nf_conntrack_h323_types.c
>>> +++ b/net/netfilter/nf_conntrack_h323_types.c
>>> @@ -1109,7 +1109,7 @@ static const struct field_t _SecurityCapabilities[] = {	/* SEQUENCE */
>>>   	 _NonStandardParameter},
>>>   	{FNAME("encryption") CHOICE, 2, 3, 3, SKIP | EXT, 0,
>>>   	 _SecurityServiceMode},
>>> -	{FNAME("authenticaton") CHOICE, 2, 3, 3, SKIP | EXT, 0,
>>> +	{FNAME("authentication") CHOICE, 2, 3, 3, SKIP | EXT, 0,
>>>   	 _SecurityServiceMode},
>>>   	{FNAME("integrity") CHOICE, 2, 3, 3, SKIP | EXT, 0,
>>>   	 _SecurityServiceMode},
> 
> https://www.itu.int/ITU-T/formal-language/itu-t/h/h225-0/2009/H323-MESSAGES.html says:
> 		         ...
> SecurityCapabilities ::= SEQUENCE {
> nonStandard    NonStandardParameter OPTIONAL,
> encryption     SecurityServiceMode,
> authenticaton  SecurityServiceMode,
> integrity      SecurityServiceMode,
> ...
> }
> 
> so this spelling seems intentional.
> 
Ah, thanks for spotting that, my bad.