netdev - Re: [PATCH ipsec-next] xfrm: kconfig: make xfrm depend on inet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190416092922.GL17989@gauss3.secunet.de>
Date:   Tue, 16 Apr 2019 11:29:22 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Florian Westphal <fw@...len.de>
CC:     <netdev@...r.kernel.org>, Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH ipsec-next] xfrm: kconfig: make xfrm depend on inet

On Fri, Apr 12, 2019 at 10:14:46AM +0200, Florian Westphal wrote:
> when CONFIG_INET is not enabled:
> net/xfrm/xfrm_output.c: In function ‘xfrm4_tunnel_encap_add’:
> net/xfrm/xfrm_output.c:234:2: error: implicit declaration of function ‘ip_select_ident’ [-Werror=implicit-function-declaration]
> ip_select_ident(dev_net(dst->dev), skb, NULL);
> 
> XFRM only supports ipv4 and ipv6 so change dependency to INET and place
> user-visible options (pfkey sockets, migrate support and the like)
> under 'if INET' guard as well.
> 
> Fixes: 1de70830066b7 ("xfrm: remove output2 indirection from xfrm_mode")
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Florian Westphal <fw@...len.de>

Applied to ipsec-next, thanks Florian!