netdev - Re: linux-next: build warning after merge of the net-next tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK+XE=m+0NMxbRSTa05n0wJU3EuF=oVwA9aCirs2Dq3AcO7bjw@mail.gmail.com>
Date:   Tue, 16 Apr 2019 11:03:21 +0100
From:   John Hurley <john.hurley@...ronome.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     David Miller <davem@...emloft.net>,
        Networking <netdev@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Simon Horman <simon.horman@...ronome.com>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Kees Cook <keescook@...omium.org>
Subject: Re: linux-next: build warning after merge of the net-next tree

On Tue, Apr 16, 2019 at 2:21 AM Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> Hi all,
>
> After merging the net-next tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/net/ethernet/netronome/nfp/flower/offload.c: In function 'nfp_flower_copy_pre_actions':
> drivers/net/ethernet/netronome/nfp/flower/offload.c:630:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
>     if (tunnel_act)
>        ^
> drivers/net/ethernet/netronome/nfp/flower/offload.c:632:3: note: here
>    case NFP_FL_ACTION_OPCODE_PRE_LAG:
>    ^~~~
>
> Introduced by commit
>
>   1c6952ca587d ("nfp: flower: generate merge flow rule")
>
> I get this warning because I am building with -Wimplicit-fallthrough
> in attempt to catch new additions early.  The gcc warning can be turned
> off by adding a /* fall through */ comment at the point the fall through
> happens (assuming that the fall through is intentional).
>

Hi Stephen,
Thanks for flagging this.
The fall through is intentional.
I'll submit a fix for the warning.
John

> --
> Cheers,
> Stephen Rothwell