netdev - Re: [PATCH] of_net: add mtd-mac-address support to of_get_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190417121044.GC79403@meh.true.cz>
Date:   Wed, 17 Apr 2019 14:10:44 +0200
From:   Petr Štetiar <ynezz@...e.cz>
To:     Maxime Ripard <maxime.ripard@...tlin.com>
Cc:     netdev@...r.kernel.org, devicetree@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Frank Rowand <frowand.list@...il.com>,
        John Crispin <john@...ozen.org>, Felix Fietkau <nbd@....name>
Subject: Re: [PATCH] of_net: add mtd-mac-address support to
 of_get_mac_address()

Maxime Ripard <maxime.ripard@...tlin.com> [2019-04-17 12:15:57]:

> https://elixir.bootlin.com/linux/latest/source/net/ethernet/eth.c#L564

Thanks, so if I parse those 2 use cases of nvmem_get_mac_address correctly:

 drivers/net/ethernet/cadence/macb_main.c:  err = nvmem_get_mac_address(&pdev->dev, bp->dev->dev_addr);
 drivers/net/ethernet/ti/davinci_emac.c:    rc = nvmem_get_mac_address(&pdev->dev, priv->mac_addr);

We would need to spill `nvmem_get_mac_address` into every single driver on
earth (as it's done now in those two drivers I've mentioned above) which would
like to use MAC address stored in NVME or wire `nvmem_get_mac_address` into
`of_get_mac_address`, right?

-- ynezz