netdev - Re: [PATCH v11 3/7] anybus-s: support the Arcx anybus controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGngYiXd34hTriDsKvhOWogaF0uLfVbUn5BzJc3cUnZcWpFXAg@mail.gmail.com>
Date:   Wed, 17 Apr 2019 10:17:11 -0400
From:   Sven Van Asbroeck <thesven73@...il.com>
To:     "Enrico Weigelt, metux IT consult" <lkml@...ux.net>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Lee Jones <lee.jones@...aro.org>, mark.rutland@....com,
        Andreas Färber <afaerber@...e.de>,
        treding@...dia.com, David Lechner <david@...hnology.com>,
        noralf@...nnes.org, johan@...nel.org,
        Michal Simek <monstr@...str.eu>, michal.vokac@...ft.com,
        Arnd Bergmann <arnd@...db.de>,
        Greg KH <gregkh@...uxfoundation.org>, john.garry@...wei.com,
        geert+renesas@...der.be, robin.murphy@....com,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        sebastien.bourdelin@...oirfairelinux.com, icenowy@...c.io,
        Stuart Yoder <stuyoder@...il.com>,
        "J. Kiszka" <jan.kiszka@...mens.com>, maxime.ripard@...tlin.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v11 3/7] anybus-s: support the Arcx anybus controller

On Wed, Apr 17, 2019 at 4:41 AM Enrico Weigelt, metux IT consult
<lkml@...ux.net> wrote:
> hmm, I think the main question here is clean separation between
> subsystems - devices that span multiple subsystems, IMHO, fall
> into the category "mfd".
>

Generally I agree wholeheartedly, but as we discussed,
it might not be worth the trouble in this case.

> separate drivers probably don't make much sense here, but maybe
> a CONFIG_ flag for disabling this functionality ?

Yes, I can add that for sure !

>
> hmm, wouldn't the input subsystem be more appropriate for that ?
>

The input subsystem is concerned with input from humans?
But in this case, it's really a power output from an external card
on a PCB assembly. Regulator seemed the kernel abstraction
closest to what this actually represents.

I'm honestly not fully satisfied by the use of the regulator
abstraction here. If you know of a different abstraction
which seems better, I'll definitely consider it.