lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 17 Apr 2019 18:29:13 +0200
From:   Julian Wiedmann <>
To:     David Miller <>
Cc:     <>, <>,
        Martin Schwidefsky <>,
        Heiko Carstens <>,
        Stefan Raspl <>,
        Ursula Braun <>,
        Arnd Bergmann <>,
        Julian Wiedmann <>
Subject: [PATCH net] s390: ctcm: fix ctcm_new_device error return code

From: Arnd Bergmann <>

clang points out that the return code from this function is
undefined for one of the error paths:

../drivers/s390/net/ctcm_main.c:1595:7: warning: variable 'result' is used uninitialized whenever 'if' condition is true
                if (priv->channel[direction] == NULL) {
../drivers/s390/net/ctcm_main.c:1638:9: note: uninitialized use occurs here
        return result;
../drivers/s390/net/ctcm_main.c:1595:3: note: remove the 'if' if its condition is always false
                if (priv->channel[direction] == NULL) {
../drivers/s390/net/ctcm_main.c:1539:12: note: initialize the variable 'result' to silence this warning
        int result;

Make it return -ENODEV here, as in the related failure cases.
gcc has a known bug in underreporting some of these warnings
when it has already eliminated the assignment of the return code
based on some earlier optimization step.

Reviewed-by: Nathan Chancellor <>
Signed-off-by: Arnd Bergmann <>
Signed-off-by: Julian Wiedmann <>
 drivers/s390/net/ctcm_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/s390/net/ctcm_main.c b/drivers/s390/net/ctcm_main.c
index 7617d21cb296..f63c5c871d3d 100644
--- a/drivers/s390/net/ctcm_main.c
+++ b/drivers/s390/net/ctcm_main.c
@@ -1595,6 +1595,7 @@ static int ctcm_new_device(struct ccwgroup_device *cgdev)
 		if (priv->channel[direction] == NULL) {
 			if (direction == CTCM_WRITE)
+			result = -ENODEV;
 			goto out_dev;
 		priv->channel[direction]->netdev = dev;

Powered by blists - more mailing lists