netdev - Re: [PATCH bpf] bpf: allow clearing all sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQJFXEe3mtdVg-7thR0MTM=GdBDSDOtkcfaF48zhDHK41A@mail.gmail.com>
Date:   Tue, 16 Apr 2019 19:27:07 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Viet Hoang Tran <hoang.tran@...ouvain.be>
Cc:     "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        "David S. Miller" <davem@...emloft.net>,
        Lawrence Brakmo <brakmo@...com>, Martin Lau <kafai@...com>,
        Quentin Monnet <quentin.monnet@...ronome.com>,
        "tranviethoang.vn@...il.com" <tranviethoang.vn@...il.com>
Subject: Re: [PATCH bpf] bpf: allow clearing all sock_ops callback flags

On Mon, Apr 15, 2019 at 2:55 AM Viet Hoang Tran <hoang.tran@...ouvain.be> wrote:
>
> The helper function bpf_sock_ops_cb_flags_set() can be used to both
> set and clear the sock_ops callback flags. However, its current
> behavior is not consistent. BPF program may clear a flag if more than
> one were set, or replace a flag with another one, but cannot clear all
> flags.
>
> This patch also updates the documentation to clarify the ability to
> clear flags of this helper function.
>
> Signed-off-by: Hoang Tran <hoang.tran@...ouvain.be>

Applied. Thanks