lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 17 Apr 2019 17:56:43 -0400
From:   Willem de Bruijn <>
To:     Arnd Bergmann <>
Cc:     Network Development <>,
        "David S. Miller" <>,
        y2038 Mailman List <>,
        Deepa Dinamani <>,
        Stefan Schmidt <>,
        Neil Horman <>,
        Marc Kleine-Budde <>,
        Eric Dumazet <>,
        Willem de Bruijn <>,
        LKML <>,,
        Bluez mailing list <>,,,,,
Subject: Re: [PATCH v3 1/3] net: rework SIOCGSTAMP ioctl handling

On Wed, Apr 17, 2019 at 4:54 PM Arnd Bergmann <> wrote:
> The SIOCGSTAMP/SIOCGSTAMPNS ioctl commands are implemented by many
> socket protocol handlers, and all of those end up calling the same
> sock_get_timestamp()/sock_get_timestampns() helper functions, which
> results in a lot of duplicate code.
> With the introduction of 64-bit time_t on 32-bit architectures, this
> gets worse, as we then need four different ioctl commands in each
> socket protocol implementation.
> To simplify that, let's add a new .gettstamp() operation in
> struct proto_ops, and move ioctl implementation into the common
> sock_ioctl()/compat_sock_ioctl_trans() functions that these all go
> through.
> We can reuse the sock_get_timestamp() implementation, but generalize
> it so it can deal with both native and compat mode, as well as
> timeval and timespec structures.
> Acked-by: Stefan Schmidt <>
> Acked-by: Neil Horman <>
> Acked-by: Marc Kleine-Budde <>
> Link:
> Signed-off-by: Arnd Bergmann <>

Acked-by: Willem de Bruijn <>

Powered by blists - more mailing lists