netdev - Re: [PATCH net-next] xsk: Have xsk_umem_peek_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190417145932.4d696a29@cakuba.netronome.com>
Date:   Wed, 17 Apr 2019 14:59:32 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Jonathan Lemon <jonathan.lemon@...il.com>
Cc:     <netdev@...r.kernel.org>, <maximmi@...lanox.com>,
        <bjorn.topel@...el.com>, <kernel-team@...com>
Subject: Re: [PATCH net-next] xsk: Have xsk_umem_peek_addr_rq() return
 chunk-aligned handles.

On Wed, 17 Apr 2019 12:52:55 -0700, Jonathan Lemon wrote:
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c
> index 61d75a7b3ce2..2f0b5fd1ee97 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c
> @@ -309,7 +309,7 @@ int mlx5e_xsk_page_alloc_umem(struct mlx5e_rq *rq,
>  
>  static inline void mlx5e_xsk_recycle_frame(struct mlx5e_rq *rq, u64 handle)
>  {
> -	xsk_umem_fq_reuse(rq->umem, handle & rq->umem->chunk_mask);
> +	xsk_umem_fq_reuse(rq->umem, handle);
>  }
>  

The mlx5 af_xdp stuff you're using is not upstream :)