netdev - Re: [PATCH v3 net-next 23/24] Documentation: net: dsa: Add details about NXP SJA1105 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a09bdb25-6d18-b9f0-2be8-da9ad174ace8@gmail.com>
Date:   Tue, 16 Apr 2019 17:20:47 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>, vivien.didelot@...il.com,
        andrew@...n.ch, davem@...emloft.net
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        georg.waibel@...sor-technik.de
Subject: Re: [PATCH v3 net-next 23/24] Documentation: net: dsa: Add details
 about NXP SJA1105 driver



On 12/04/2019 18:28, Vladimir Oltean wrote:

[snip]

> +Segregating the switch ports in multiple bridges is supported (e.g. 2 + 2), but
> +all bridges should have the same level of VLAN awareness (either both have
> +``vlan_filtering`` 0, or both 1). Also an inevitable limitation of the fact
> +that VLAN awareness is global at the switch level is that once a bridge with
> +``vlan_filtering`` enslaves at least one switch port, the other un-bridged
> +ports are no longer available for standalone traffic termination.

That is quite a limitation that I don't think I had fully grasped until 
reading your different patches. Since enslaving ports into a bridge 
comes after the network device was already made available for use, maybe 
you should force the carrier down or something along those lines as soon 
as a port is enslaved into a bridge with vlan_filtering=1 to make this 
more predictable for the user?
-- 
Florian