netdev - Re: [PATCH] net: atm: Fix potential Spectre v1 vulnerabilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dc574274-8405-a7a9-8bde-a928218f51cc@embeddedor.com>
Date:   Tue, 16 Apr 2019 23:05:54 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: atm: Fix potential Spectre v1 vulnerabilities



On 4/16/19 11:02 PM, David Miller wrote:
> From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
> Date: Mon, 15 Apr 2019 15:57:23 -0500
> 
>> arg is controlled by user-space, hence leading to a potential
>> exploitation of the Spectre variant 1 vulnerability.
>>
>> This issue was detected with the help of Smatch:
>>
>> net/atm/lec.c:715 lec_mcast_attach() warn: potential spectre issue 'dev_lec' [r] (local cap)
>>
>> Fix this by sanitizing arg before using it to index dev_lec.
>>
>> Notice that given that speculation windows are large, the policy is
>> to kill the speculation on the first load and not worry if it can be
>> completed with a dependent load/store [1].
>>
>> [1] https://lore.kernel.org/lkml/20180423164740.GY17484@dhcp22.suse.cz/
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> 
> Applied and queued up for -stable.
> 

Thank you, Dave.

--
Gustavo