netdev - Re: [PATCH net-next 1/1] nfp: flower: fix implicit fallthrough warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190416.214225.932449761026490084.davem@davemloft.net>
Date:   Tue, 16 Apr 2019 21:42:25 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     john.hurley@...ronome.com
Cc:     simon.horman@...ronome.com, jakub.kicinski@...ronome.com,
        netdev@...r.kernel.org, sfr@...b.auug.org.au,
        oss-drivers@...ronome.com
Subject: Re: [PATCH net-next 1/1] nfp: flower: fix implicit fallthrough
 warning

From: John Hurley <john.hurley@...ronome.com>
Date: Tue, 16 Apr 2019 15:04:23 +0100

> The nfp_flower_copy_pre_actions function introduces a case statement with
> an intentional fallthrough. However, this generates a warning if built
> with the -Wimplicit-fallthrough flag.
> 
> Remove the warning by adding a fall through comment.
> 
> Fixes: 1c6952ca587d ("nfp: flower: generate merge flow rule")
> Signed-off-by: John Hurley <john.hurley@...ronome.com>
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Reviewed-by: Jiong Wang <jiong.wang@...ronome.com>
> Reviewed-by: Simon Horman <simon.horman@...ronome.com>

Applied.