netdev - Re: [PATCH net-next 02/15] dsa: Move tagger name into its ops structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a327d49b-5a2a-56ba-618c-9348c246de2d@gmail.com>
Date:   Thu, 18 Apr 2019 10:37:20 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [PATCH net-next 02/15] dsa: Move tagger name into its ops
 structure



On 4/17/2019 7:31 PM, Andrew Lunn wrote:
> Rather than keep a list to map a tagger ops to a name, place the name
> into the ops structure. This removes the hard coded list, a stop
> towards making the taggers more dynamic.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> ---

[snip]

> diff --git a/include/net/dsa.h b/include/net/dsa.h
> index 0cfc2f828b87..9bcbbde0f61d 100644
> --- a/include/net/dsa.h
> +++ b/include/net/dsa.h
> @@ -50,6 +50,7 @@ struct packet_type;
>  struct dsa_switch;
>  
>  struct dsa_device_ops {
> +	const char *name;

Nit: I would place this after the xmit and rcv function pointers since
we do not control how big the name is and it could theoretically push us
one cache line down... With that:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian