netdev - Re: [PATCH] stmmac: pci: Adjust IOT2000 matching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <642a6059-8a28-b995-919f-68d03200ee11@siemens.com>
Date:   Thu, 18 Apr 2019 20:24:28 +0200
From:   Jan Kiszka <jan.kiszka@...mens.com>
To:     David Miller <davem@...emloft.net>
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        baocheng.su@...mens.com, andy.shevchenko@...il.com
Subject: Re: [PATCH] stmmac: pci: Adjust IOT2000 matching

On 18.04.19 19:43, David Miller wrote:
> From: Jan Kiszka <jan.kiszka@...mens.com>
> Date: Thu, 18 Apr 2019 11:14:56 +0200
> 
>> @@ -170,8 +176,6 @@ static const struct dmi_system_id quark_pci_dmi[] = {
>>   	{
>>   		.matches = {
>>   			DMI_EXACT_MATCH(DMI_BOARD_NAME, "SIMATIC IOT2000"),
>> -			DMI_EXACT_MATCH(DMI_BOARD_ASSET_TAG,
>> -					"6ES7647-0AA00-1YA2"),
>>   		},
>>   		.driver_data = (void *)&iot2040_stmmac_dmi_data,
> 
> So really, every IOT2000 that doesn't have the IOT2020 asset tag will be
> a 2040?  Forever?
> 

Yes, seriously. The next version won't have all that DMI and ACPI stuff. And if 
there will ever be a version with that again, it will not be labeled "IOT2000" 
via the board name entry. And it will have more robust hardware discovery as 
well. Lesson(s) learned, in fact not only for this product series.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux