netdev - Re: [PATCH bpf-next] libbpf: remove compile time warning from libbpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH3MdRUgxSqvUdxdnx=ZTodNPXaPHP-4gaKicVQNMavePSeWqw@mail.gmail.com>
Date:   Thu, 18 Apr 2019 13:58:52 -0700
From:   Y Song <ys114321@...il.com>
To:     Magnus Karlsson <magnus.karlsson@...el.com>
Cc:     Björn Töpel <bjorn.topel@...el.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        netdev <netdev@...r.kernel.org>, bpf@...r.kernel.org
Subject: Re: [PATCH bpf-next] libbpf: remove compile time warning from libbpf_util.h

On Thu, Apr 18, 2019 at 12:23 AM Magnus Karlsson
<magnus.karlsson@...el.com> wrote:
>
> Having a helpful compile time warning in libbpf_util.h is not a good
> idea since all warnings are treated as errors. Change this into a
> comment in the code instead.
>
> Fixes: b7e3a28019c9 ("libbpf: remove dependency on barrier.h in xsk.h")
> Signed-off-by: Magnus Karlsson <magnus.karlsson@...el.com>

Acked-by: Yonghong Song <yhs@...com>


> ---
>  tools/lib/bpf/libbpf_util.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/libbpf_util.h b/tools/lib/bpf/libbpf_util.h
> index 172b707e..da94c4c 100644
> --- a/tools/lib/bpf/libbpf_util.h
> +++ b/tools/lib/bpf/libbpf_util.h
> @@ -46,7 +46,7 @@ do {                          \
>  # define libbpf_smp_mb() asm volatile("dmb ish" : : : "memory")
>  # define libbpf_smp_rwmb() libbpf_smp_mb()
>  #else
> -# warning Architecture missing native barrier functions in libbpf_util.h.
> +/* Architecture missing native barrier functions. */
>  # define libbpf_smp_rmb() __sync_synchronize()
>  # define libbpf_smp_wmb() __sync_synchronize()
>  # define libbpf_smp_mb() __sync_synchronize()
> --
> 2.7.4
>