netdev - Re: [PATCH bpf-next] selftests/bpf: fix a compilation error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQLCx8FX83mST+=+x=QgCFQ+V276hc-D8ueh3hoTXbOsAg@mail.gmail.com>
Date:   Wed, 17 Apr 2019 22:31:22 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Yonghong Song <yhs@...com>
Cc:     bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next] selftests/bpf: fix a compilation error

On Wed, Apr 17, 2019 at 10:23 PM Yonghong Song <yhs@...com> wrote:
>
> I hit the following compilation error with gcc 4.8.5.
>
>   prog_tests/flow_dissector.c: In function ‘test_flow_dissector’:
>   prog_tests/flow_dissector.c:155:2: error: ‘for’ loop initial declarations are only allowed in C99 mode
>     for (int i = 0; i < ARRAY_SIZE(tests); i++) {
>     ^
>   prog_tests/flow_dissector.c:155:2: note: use option -std=c99 or -std=gnu99 to compile your code
>
> Let us fix the issue by avoiding this particular c99 feature.
>
> Fixes: a5cb33464e53 ("selftests/bpf: make flow dissector tests more extensible")
> Signed-off-by: Yonghong Song <yhs@...com>

Applied. Thanks