netdev - Re: [PATCH net-next v2 4/5] bridge: update vlan dev state when port added to or deleted from vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <85f7e246-f69c-85f0-0ed5-247082b02512@cumulusnetworks.com>
Date:   Thu, 18 Apr 2019 14:41:09 +0300
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Mike Manning <mmanning@...tta.att-mail.com>,
        netdev@...r.kernel.org, roopa@...ulusnetworks.com
Subject: Re: [PATCH net-next v2 4/5] bridge: update vlan dev state when port
 added to or deleted from vlan

On 17/04/2019 21:16, Mike Manning wrote:
> If vlan bridge binding is enabled, then the link state of a vlan device
> that is an upper device of the bridge should track the state of bridge
> ports that are members of that vlan. So if a bridge port becomes or
> stops being a member of a vlan, then update the link state of the
> vlan device if necessary.
> 
> Signed-off-by: Mike Manning <mmanning@...tta.att-mail.com>
> ---
>  net/bridge/br_vlan.c | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/net/bridge/br_vlan.c b/net/bridge/br_vlan.c
> index b903689a8fc5..89146a5f0c23 100644
> --- a/net/bridge/br_vlan.c
> +++ b/net/bridge/br_vlan.c
> @@ -7,6 +7,8 @@
>  #include "br_private.h"
>  #include "br_private_tunnel.h"
>  
> +static void nbp_vlan_set_vlan_dev_state(struct net_bridge_port *p, u16 vid);
> +
>  static inline int br_vlan_cmp(struct rhashtable_compare_arg *arg,
>  			      const void *ptr)
>  {
> @@ -293,6 +295,9 @@ static int __vlan_add(struct net_bridge_vlan *v, u16 flags,
>  
>  	__vlan_add_list(v);
>  	__vlan_add_flags(v, flags);
> +
> +	if (p)
> +		nbp_vlan_set_vlan_dev_state(p, v->vid);

Not a fan of this conditional here, but I guess you want to affect state after the
vlan has been inserted to avoid packet loss in the short window while it's happening. 

>  out:
>  	return err;
>  
> @@ -357,6 +362,7 @@ static int __vlan_del(struct net_bridge_vlan *v)
>  		rhashtable_remove_fast(&vg->vlan_hash, &v->vnode,
>  				       br_vlan_rht_params);
>  		__vlan_del_list(v);
> +		nbp_vlan_set_vlan_dev_state(p, v->vid);
>  		call_rcu(&v->rcu, nbp_vlan_rcu_free);
>  	}
>  
> @@ -1388,6 +1394,19 @@ static void br_vlan_upper_change(struct net_device *dev,
>  }
>  
>  /* Must be protected by RTNL. */
> +static void nbp_vlan_set_vlan_dev_state(struct net_bridge_port *p, u16 vid)
> +{
> +	struct net_device *vlan_dev;
> +
> +	if (!br_opt_get(p->br, BROPT_VLAN_BRIDGE_BINDING))
> +		return;
> +
> +	vlan_dev = br_vlan_get_upper_bind_vlan_dev(p->br->dev, vid);
> +	if (vlan_dev)
> +		br_vlan_set_vlan_dev_state(p->br, vlan_dev);
> +}
> +
> +/* Must be protected by RTNL. */
>  void br_vlan_bridge_event(struct net_device *dev, unsigned long event,
>  			  void *ptr)
>  {
> 

Acked-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>