netdev - Re: [PATCH net-next v3 0/5] net: support binding vlan dev link state to vlan member bridge ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190419.135839.1127694128904625165.davem@davemloft.net>
Date:   Fri, 19 Apr 2019 13:58:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mmanning@...tta.att-mail.com
Cc:     netdev@...r.kernel.org, nikolay@...ulusnetworks.com,
        roopa@...ulusnetworks.com
Subject: Re: [PATCH net-next v3 0/5] net: support binding vlan dev link
 state to vlan member bridge ports

From: Mike Manning <mmanning@...tta.att-mail.com>
Date: Thu, 18 Apr 2019 18:35:30 +0100

> For vlan filtering on bridges, the bridge may also have vlan devices
> as upper devices. For switches, these are used to provide L3 packet
> processing for ports that are members of a given vlan.
> 
> While it is correct that the admin state for these vlan devices is
> either set directly for the device or inherited from the lower device,
> the link state is also transferred from the lower device. So this is
> always up if the bridge is in admin up state and there is at least one
> bridge port that is up, regardless of the vlan that the port is in.
> 
> The link state of the vlan device may need to track only the state of
> the subset of ports that are also members of the corresponding vlan,
> rather than that of all ports.
> 
> This series provides an optional vlan flag so that the link state of
> the vlan device is only up if there is at least one bridge port that is
> up AND is a member of the corresponding vlan.
> 
> v2:
>    - Address review comments from Nikolay Aleksandrov
>      in patches 3 & 4 and add patch 5 to address bridge link down due to STP
> v3:
>    - Address review comment from Nikolay Aleksandrov
>      in patch 4 so as to remove unnecessary inline #ifdef

Series applied, thanks Mike.