netdev - Re: [patch net-next 14/15] netdevsim: move netdev creation/destruction to dev probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190419141119.79fd9020@cakuba.netronome.com>
Date:   Fri, 19 Apr 2019 14:11:19 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, mlxsw@...lanox.com,
        dsahern@...il.com
Subject: Re: [patch net-next 14/15] netdevsim: move netdev
 creation/destruction to dev probe

On Fri, 19 Apr 2019 07:28:33 +0200, Jiri Pirko wrote:
> Thu, Apr 18, 2019 at 07:25:50PM CEST, jakub.kicinski@...ronome.com wrote:
> >On Thu, 18 Apr 2019 16:06:13 +0200, Jiri Pirko wrote:  
> >> -    simB3.remove()
> >> +    simdevB.remove()
> >>      bpftool_prog_list_wait(expected=0)
> >>  
> >>      start_test("Test multi-dev ASIC cross-dev destruction - orphaned...")  
> >
> >You're removing existing tests in the name of reshuffling the code?  
> 
> Okay, as you wish. I will add way to add/del ports on fly.

Yes I wish we add tests instead of removing them.

Please show us the tests you're going to add once you're through with
all this core reshuffling.  Maybe it'd make it easier to swallow.