netdev - Re: [PATCH] net/mlx5e: remove meaningless CFLAGS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d938a56a3350fba18bd23f43efb582835c90c94d.camel@mellanox.com>
Date:   Fri, 19 Apr 2019 23:16:31 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "yamada.masahiro@...ionext.com" <yamada.masahiro@...ionext.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "leon@...nel.org" <leon@...nel.org>
Subject: Re: [PATCH] net/mlx5e: remove meaningless CFLAGS_tracepoint.o

On Fri, 2019-04-19 at 14:17 +0900, Masahiro Yamada wrote:
> CFLAGS_tracepoint.o specifies CFLAGS for compiling tracepoint.c but
> it does not exist under drivers/net/ethernet/mellanox/mlx5/core/.
> 
> CFLAGS_tracepoint.o is unused.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
>  drivers/net/ethernet/mellanox/mlx5/core/Makefile | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Makefile
> b/drivers/net/ethernet/mellanox/mlx5/core/Makefile
> index 1a16f6d73cbc..fa12c2ca9fc5 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/Makefile
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/Makefile
> @@ -57,5 +57,3 @@ mlx5_core-$(CONFIG_MLX5_EN_IPSEC) +=
> en_accel/ipsec.o en_accel/ipsec_rxtx.o \
>  				     en_accel/ipsec_stats.o
>  
>  mlx5_core-$(CONFIG_MLX5_EN_TLS) += en_accel/tls.o
> en_accel/tls_rxtx.o en_accel/tls_stats.o
> -
> -CFLAGS_tracepoint.o := -I$(src)

LGTM, applied to mlx5 branch, will be sent upstream shortly.

Thanks,
Saeed.