netdev - Re: [PATCH net-next 0/5] net: some build fixes and other improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190418173407.3909143b@cakuba.netronome.com>
Date:   Thu, 18 Apr 2019 17:34:07 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        Guillaume Nault <g.nault@...halink.fr>
Subject: Re: [PATCH net-next 0/5] net: some build fixes and other
 improvements

On Thu, 18 Apr 2019 17:06:47 -0700 (PDT), David Miller wrote:
> From: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Date: Wed, 17 Apr 2019 13:51:54 -0700
> 
> > A few unrelated improvements here, mostly trying to make random
> > configs build and W=1 produce a little less warnings under net/
> > and drivers net/.
> > 
> > First two patches fix set but not used warnings with W=1.
> > 
> > Next patch fixes 64bit division in sch_taprio.c.
> > 
> > Last two patches are getting rid of some (almost) unused asserts
> > in skbuff.h.  
> 
> Series applied, thanks Jakub.

Thanks!

> That l2tp one was weird, apparently that value was never ever used.

Yess, the only explanation I could come up with was that Guillaume
wanted to make sure user space passed a valid pointer, even if it's
unused today.  But that's pure speculation :S