netdev - Re: [PATCH net-next 07/15] dsa: Add boilerplate helper to register DSA tag driver modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc70e807-ee6e-a6c2-4e8b-ae1983e9ded1@gmail.com>
Date:   Fri, 19 Apr 2019 08:29:48 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [PATCH net-next 07/15] dsa: Add boilerplate helper to register
 DSA tag driver modules



On 4/17/2019 7:31 PM, Andrew Lunn wrote:
> A DSA tag driver module will need to register the tag protocols it
> implements with the DSA core. Add a macro containing this boiler plate.
> 
> The registration/unregistration code is currently just a stub. A Later
> patch will add the real implementation.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> ---
[snip]

> diff --git a/net/dsa/tag_brcm.c b/net/dsa/tag_brcm.c
> index 756bade54fee..bff9b03a7752 100644
> --- a/net/dsa/tag_brcm.c
> +++ b/net/dsa/tag_brcm.c
> @@ -205,3 +205,14 @@ struct dsa_device_ops brcm_prepend_netdev_ops = {
>  
>  MODULE_LICENSE("GPL");
>  MODULE_ALIAS_DSA_TAG_DRIVER(DSA_TAG_PROTO_BRCM_PREPEND);
> +
> +static struct dsa_device_ops *ops_array[] = {
> +#ifdef CONFIG_NET_DSA_TAG_BRCM
> +	&brcm_netdev_ops,
> +	#endif
> +#ifdef CONFIG_NET_DSA_TAG_BRCM_PREPEND
> +	&brcm_prepend_netdev_ops,
> +	#endif
> +};

The indentation for the two #endif is off by one tab here. Other than that:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian