netdev - Re: [PATCH net-next 15/15] dsa: tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f16284d9-ef44-8ff2-67fb-22d81001e661@gmail.com>
Date:   Fri, 19 Apr 2019 08:39:42 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [PATCH net-next 15/15] dsa: tag_brcm: Avoid unused symbols



On 4/17/2019 7:31 PM, Andrew Lunn wrote:
> It is possible that the driver is compiled with both
> CONFIG_NET_DSA_TAG_BRCM and CONFIG_NET_DSA_TAG_BRCM_PREPEND disabled.
> This results in warnings about unused symbols. Add some conditional
> compilation to avoid this.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Would not you want to re-order this patch such that it comes before
patch 14 and there is not possibility of generating unused symbols warnings?
-- 
Florian