netdev - Re: [PATCH] of_net: Fix residues after of_get_nvmem_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190419.115844.903040716308076686.davem@davemloft.net>
Date:   Fri, 19 Apr 2019 11:58:44 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ynezz@...e.cz
Cc:     netdev@...r.kernel.org, devicetree@...r.kernel.org,
        robh+dt@...nel.org, mark.rutland@....com, andrew@...n.ch,
        f.fainelli@...il.com, hkallweit1@...il.com, frowand.list@...il.com,
        bgolaszewski@...libre.com
Subject: Re: [PATCH] of_net: Fix residues after of_get_nvmem_mac_address
 removal

From: Petr Štetiar <ynezz@...e.cz>
Date: Wed, 17 Apr 2019 22:09:12 +0200

> I've discovered following discrepancy in the bindings/net/ethernet.txt
> documentation, where it states following:
> 
>  - nvmem-cells: phandle, reference to an nvmem node for the MAC address;
>  - nvmem-cell-names: string, should be "mac-address" if nvmem is to be..
> 
> which is actually misleading and confusing. There are only two ethernet
> drivers in the tree, cadence/macb and davinci which supports this
> properties.
> 
> This nvmem-cell* properties were introduced in commit 9217e566bdee
> ("of_net: Implement of_get_nvmem_mac_address helper"), but
> commit afa64a72b862 ("of: net: kill of_get_nvmem_mac_address()")
> forget to properly clean up this parts.
> 
> So this patch fixes the documentation by moving the nvmem-cell*
> properties at the appropriate places.  While at it, I've removed unused
> include as well.
> 
> Cc: Bartosz Golaszewski <bgolaszewski@...libre.com>
> Fixes: afa64a72b862 ("of: net: kill of_get_nvmem_mac_address()")
> Signed-off-by: Petr Štetiar <ynezz@...e.cz>

Applied, thanks.