netdev - Re: [PATCH net] net/tls: avoid potential deadlock in tls_set_device_offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190420.203617.1908802766734736950.davem@davemloft.net>
Date:   Sat, 20 Apr 2019 20:36:17 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        alexei.starovoitov@...il.com, davejwatson@...com,
        borisp@...lanox.com, aviadye@...lanox.com,
        dirk.vandermerwe@...ronome.com
Subject: Re: [PATCH net] net/tls: avoid potential deadlock in
 tls_set_device_offload_rx()

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Fri, 19 Apr 2019 16:51:38 -0700

> If device supports offload, but offload fails tls_set_device_offload_rx()
> will call tls_sw_free_resources_rx() which (unhelpfully) releases
> and reacquires the socket lock.
> 
> For a small fix release and reacquire the device_offload_lock.
> 
> Fixes: 4799ac81e52a ("tls: Add rx inline crypto offload")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@...ronome.com>

Applied and queued up for -stable, thanks.